diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-01-13 07:07:16 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-01-13 07:07:16 +0000 |
| commit | f18e7f6920590ee6f2e59be508518b70a4611638 (patch) | |
| tree | 2f80c427e740c2c6f7f2a47be2b869b6d9847e58 /worker_test.go | |
| parent | 5dc83ef5eee77f4d1ef557e5f8b566e75892680d (diff) | |
| parent | bbfcd4fb6eb138c616dab01ea610fbf6ed15985b (diff) | |
Merge #472
472: feat(http): Distinct app and internal error codes in the handleError function r=48d90782 a=48d90782
This PR introduces distinct error codes for the app and internal RR errors.
Errors:
```go
roadrunner.ErrNoAssociatedPool
roadrunner.ErrAllocateWorker
roadrunner.ErrWorkerNotReady
roadrunner.ErrEmptyPayload
roadrunner.ErrPoolStopped
roadrunner.ErrWorkerAllocateTimeout
roadrunner.ErrAllWorkersAreDead
```
now associated with the internal error codes. All other errors are application errors.
Some types of errors are impossible to distinguish in the RR1, for example `json.Unmarshall` internal error or similar.
The `.rr.yaml` now contain two more options for the errors.
```yaml
http:
internalErrorCode: 502,
appErrorCode: 502
```
Default behavior unchanged (500 error code as before), but now might be overridden.
closes #471
Co-authored-by: Valery Piashchynski <[email protected]>
Diffstat (limited to 'worker_test.go')
| -rw-r--r-- | worker_test.go | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/worker_test.go b/worker_test.go index c21e67cb..8f93ee96 100644 --- a/worker_test.go +++ b/worker_test.go @@ -1,10 +1,11 @@ package roadrunner import ( - "github.com/stretchr/testify/assert" "os/exec" "testing" "time" + + "github.com/stretchr/testify/assert" ) func Test_GetState(t *testing.T) { @@ -112,7 +113,7 @@ func Test_NotStarted_Exec(t *testing.T) { assert.Error(t, err) assert.Nil(t, res) - assert.Equal(t, "worker is not ready (inactive)", err.Error()) + assert.Equal(t, "worker is not ready", err.Error()) } func Test_String(t *testing.T) { |