diff options
author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-01-13 07:07:16 +0000 |
---|---|---|
committer | GitHub <[email protected]> | 2021-01-13 07:07:16 +0000 |
commit | f18e7f6920590ee6f2e59be508518b70a4611638 (patch) | |
tree | 2f80c427e740c2c6f7f2a47be2b869b6d9847e58 /service/reload | |
parent | 5dc83ef5eee77f4d1ef557e5f8b566e75892680d (diff) | |
parent | bbfcd4fb6eb138c616dab01ea610fbf6ed15985b (diff) |
Merge #472
472: feat(http): Distinct app and internal error codes in the handleError function r=48d90782 a=48d90782
This PR introduces distinct error codes for the app and internal RR errors.
Errors:
```go
roadrunner.ErrNoAssociatedPool
roadrunner.ErrAllocateWorker
roadrunner.ErrWorkerNotReady
roadrunner.ErrEmptyPayload
roadrunner.ErrPoolStopped
roadrunner.ErrWorkerAllocateTimeout
roadrunner.ErrAllWorkersAreDead
```
now associated with the internal error codes. All other errors are application errors.
Some types of errors are impossible to distinguish in the RR1, for example `json.Unmarshall` internal error or similar.
The `.rr.yaml` now contain two more options for the errors.
```yaml
http:
internalErrorCode: 502,
appErrorCode: 502
```
Default behavior unchanged (500 error code as before), but now might be overridden.
closes #471
Co-authored-by: Valery Piashchynski <[email protected]>
Diffstat (limited to 'service/reload')
-rw-r--r-- | service/reload/config.go | 3 | ||||
-rw-r--r-- | service/reload/config_test.go | 3 |
2 files changed, 4 insertions, 2 deletions
diff --git a/service/reload/config.go b/service/reload/config.go index efc71972..46267045 100644 --- a/service/reload/config.go +++ b/service/reload/config.go @@ -2,9 +2,10 @@ package reload import ( "errors" + "time" + "github.com/spiral/roadrunner" "github.com/spiral/roadrunner/service" - "time" ) // Config is a Reload configuration point. diff --git a/service/reload/config_test.go b/service/reload/config_test.go index 600975d3..b0620aa1 100644 --- a/service/reload/config_test.go +++ b/service/reload/config_test.go @@ -1,9 +1,10 @@ package reload import ( - "github.com/stretchr/testify/assert" "testing" "time" + + "github.com/stretchr/testify/assert" ) func Test_Config_Valid(t *testing.T) { |