diff options
| author | bors[bot] <26634292+bors[bot]@users.noreply.github.com> | 2021-01-13 07:07:16 +0000 |
|---|---|---|
| committer | GitHub <[email protected]> | 2021-01-13 07:07:16 +0000 |
| commit | f18e7f6920590ee6f2e59be508518b70a4611638 (patch) | |
| tree | 2f80c427e740c2c6f7f2a47be2b869b6d9847e58 /service/metrics/config_test.go | |
| parent | 5dc83ef5eee77f4d1ef557e5f8b566e75892680d (diff) | |
| parent | bbfcd4fb6eb138c616dab01ea610fbf6ed15985b (diff) | |
Merge #472
472: feat(http): Distinct app and internal error codes in the handleError function r=48d90782 a=48d90782
This PR introduces distinct error codes for the app and internal RR errors.
Errors:
```go
roadrunner.ErrNoAssociatedPool
roadrunner.ErrAllocateWorker
roadrunner.ErrWorkerNotReady
roadrunner.ErrEmptyPayload
roadrunner.ErrPoolStopped
roadrunner.ErrWorkerAllocateTimeout
roadrunner.ErrAllWorkersAreDead
```
now associated with the internal error codes. All other errors are application errors.
Some types of errors are impossible to distinguish in the RR1, for example `json.Unmarshall` internal error or similar.
The `.rr.yaml` now contain two more options for the errors.
```yaml
http:
internalErrorCode: 502,
appErrorCode: 502
```
Default behavior unchanged (500 error code as before), but now might be overridden.
closes #471
Co-authored-by: Valery Piashchynski <[email protected]>
Diffstat (limited to 'service/metrics/config_test.go')
| -rw-r--r-- | service/metrics/config_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/service/metrics/config_test.go b/service/metrics/config_test.go index 94f97da5..5153ead1 100644 --- a/service/metrics/config_test.go +++ b/service/metrics/config_test.go @@ -11,7 +11,7 @@ import ( type mockCfg struct{ cfg string } -func (cfg *mockCfg) Get(name string) service.Config { return nil } +func (cfg *mockCfg) Get(name string) service.Config { return nil } func (cfg *mockCfg) Unmarshal(out interface{}) error { j := json.ConfigCompatibleWithStandardLibrary return j.Unmarshal([]byte(cfg.cfg), out) |