Fix panic in Serve

Add test for the bug
Uncomment test in container. It's working properly now

2 files changed, 23 insertions, 0 deletions

diff --git a/service/gzip/service.go b/service/gzip/service.go
index bb6bcfcd..5ae3ffd5 100644
--- a/service/gzip/service.go
+++ b/service/gzip/service.go
@@ -1,6 +1,7 @@
 package gzip
 
 import (
+	"errors"
 	"github.com/NYTimes/gziphandler"
 	rrhttp "github.com/spiral/roadrunner/service/http"
 	"net/http"
@@ -8,12 +9,16 @@ import (
 
 // ID contains default service name.
 const ID = "gzip"
+var httpNotInitialized = errors.New("http service should be defined properly in config")
 
 type Service struct {
 	cfg *Config
 }
 
 func (s *Service) Init(cfg *Config, r *rrhttp.Service) (bool, error) {
+	if r == nil {
+		return false, httpNotInitialized
+	}
 	s.cfg = cfg
 
 	if !s.cfg.Enable {
diff --git a/service/gzip/service_test.go b/service/gzip/service_test.go
index 858dbe56..ba14b862 100644
--- a/service/gzip/service_test.go
+++ b/service/gzip/service_test.go
@@ -47,3 +47,21 @@ func Test_Disabled(t *testing.T) {
 	assert.NotNil(t, s)
 	assert.Equal(t, service.StatusInactive, st)
 }
+
+// TEST bug #275
+func Test_Bug275(t *testing.T) {
+	logger, _ := test.NewNullLogger()
+	logger.SetLevel(logrus.DebugLevel)
+
+	c := service.NewContainer(logger)
+	c.Register(ID, &Service{})
+
+	assert.Error(t, c.Init(&testCfg{
+		httpCfg:"",
+		gzip: `{"enable":false}`,
+	}))
+
+	s, st := c.Get(ID)
+	assert.NotNil(t, s)
+	assert.Equal(t, service.StatusInactive, st)
+}