summaryrefslogtreecommitdiff
path: root/pkg
diff options
context:
space:
mode:
authorValery Piashchynski <[email protected]>2021-04-30 16:32:11 +0300
committerValery Piashchynski <[email protected]>2021-04-30 16:32:11 +0300
commit4236dfac2cd65a9031b04aa659448152868a4190 (patch)
tree591e77440a7f595d595c72cf1129e235501a75b1 /pkg
parent38021decff98dabcab873f4c258f12d122988cdd (diff)
parent009b7009885d8a15e6fa6c7e78436087b2f20129 (diff)
Merge branch 'beta' into stable
Diffstat (limited to 'pkg')
-rw-r--r--pkg/events/pool_events.go1
-rwxr-xr-xpkg/pool/static_pool.go1
-rwxr-xr-xpkg/transport/pipe/pipe_factory.go4
3 files changed, 0 insertions, 6 deletions
diff --git a/pkg/events/pool_events.go b/pkg/events/pool_events.go
index c569a5a8..e7b451e0 100644
--- a/pkg/events/pool_events.go
+++ b/pkg/events/pool_events.go
@@ -1,6 +1,5 @@
package events
-// TODO event numbers
const (
// EventWorkerConstruct thrown when new worker is spawned.
EventWorkerConstruct P = iota + 10000
diff --git a/pkg/pool/static_pool.go b/pkg/pool/static_pool.go
index 129c6f7d..06005d98 100755
--- a/pkg/pool/static_pool.go
+++ b/pkg/pool/static_pool.go
@@ -153,7 +153,6 @@ func (sp *StaticPool) Exec(p payload.Payload) (payload.Payload, error) {
}
// worker want's to be terminated
- // TODO careful with toString(rsp.Context)
if len(rsp.Body) == 0 && toString(rsp.Context) == StopRequest {
sp.stopWorker(w)
return sp.Exec(p)
diff --git a/pkg/transport/pipe/pipe_factory.go b/pkg/transport/pipe/pipe_factory.go
index 0709413f..19f4f92d 100755
--- a/pkg/transport/pipe/pipe_factory.go
+++ b/pkg/transport/pipe/pipe_factory.go
@@ -42,7 +42,6 @@ func (f *Factory) SpawnWorkerWithTimeout(ctx context.Context, cmd *exec.Cmd, lis
return
}
- // TODO why out is in?
in, err := cmd.StdoutPipe()
if err != nil {
c <- SpawnResult{
@@ -52,7 +51,6 @@ func (f *Factory) SpawnWorkerWithTimeout(ctx context.Context, cmd *exec.Cmd, lis
return
}
- // TODO why in is out?
out, err := cmd.StdinPipe()
if err != nil {
c <- SpawnResult{
@@ -119,13 +117,11 @@ func (f *Factory) SpawnWorker(cmd *exec.Cmd, listeners ...events.Listener) (*wor
return nil, errors.E(op, err)
}
- // TODO why out is in?
in, err := cmd.StdoutPipe()
if err != nil {
return nil, errors.E(op, err)
}
- // TODO why in is out?
out, err := cmd.StdinPipe()
if err != nil {
return nil, errors.E(op, err)